Name the SDK rejection in MCP invocation defects - #2014
Merged
Merged
Conversation
An MCP tools/call rejection that is neither HTTP auth nor a JSON-RPC error reaches the dispatch defect log as "MCP tool call failed for <tool>" and nothing else, so an opaque correlation id cannot be traced to a cause. Carry the SDK error class and stable code on McpInvocationError and in its message. Structural only; the SDK message is never copied, since a transport message can embed an upstream body. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | a6b38df | Sep 16 2026, 12:03 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | a6b38df | Commit Preview URL Branch Preview URL |
Sep 16 2026, 12:02 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
September 15, 2026 23:59
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2012. A
tools/callrejection that is neither an HTTP auth failure nor a JSON-RPC error still scrubs toInternal tool error [id], and the defect log for that id only saysMCP tool call failed for <tool>. Today that made a live customer failure untraceable from Axiom.McpInvocationErrornow carriessdkFailure: { name, code }(the SDK error class and its stableSdkErrorCode/ProtocolErrorCode/ HTTP status) and includes both in its message, which is what the defect log renders.Verified with the MCP plugin unit tests, typecheck, and lint.
🤖 Generated with Claude Code