updated runTask commands to use newer format#2
Open
cforsythe wants to merge 2 commits into
Open
Conversation
Author
|
There's an issue in Spigot 1.14.4 because the runTask commands change in that version of bukkit so I just made some minor changes to code to make it work. I have tested in a local minecraft server to verify it is still working as expected |
Collaborator
|
Hi and thank you for contributing. May I ask why you want to bump the Java version? Nothing I see requires features not found in Java 8. Furthermore, could you please amend your commits to avoid changing the .gitignore? |
Author
|
Hey cedeel, the travis build was not working with Java 8. and yeah I can remove the changes to .gitignore(these were files added by eclipse, which I figured you wouldn't want other people commiting :)) when I get home. Is it cool if it stays using Java 11? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.