feat: add geo-block#5625
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 22f9955 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greptile SummaryThis PR implements geo-blocking by fetching the user's IP location from
Confidence Score: 5/5Safe to merge; the geo-blocking logic is well-scoped and IP-location failures degrade gracefully (no restriction applied) without surfacing errors to pool consumers. The implementation correctly handles all edge cases examined: response.ok is checked before JSON parsing, the IP location error is logged but not propagated as a query error, existing positions are allowed through restrictions for withdraw/repay, and the modal is truly non-dismissible via keyboard/backdrop. The only note is that the acknowledgement modal's legal copy is bStocks-specific and would need updating if other gated assets are added. apps/evm/src/containers/GatedAssetAcknowledgementModal/index.tsx — the hardcoded bStocks URL and description are the only area that would need revisiting when additional gated assets are onboarded. Important Files Changed
Reviews (7): Last reviewed commit: "feat: expand geo blocker" | Re-trigger Greptile |
8d4fd85 to
b7d576a
Compare
b7d576a to
3c1b7d3
Compare
|
@greptile |
3c1b7d3 to
d00c664
Compare
d00c664 to
0171fa3
Compare
|
@greptile your first assumption is incorrect. The |
|
@greptile |
28a7224 to
474172f
Compare
474172f to
088de2b
Compare
|
@greptile |
|
@greptile |
9ee42b7 to
c776acf
Compare
c776acf to
22f9955
Compare
Jira ticket(s)
VPD-1352
Changes