Offer the queries the answer ran when suppressing them leaves nothing to click - #72
Merged
Merged
Conversation
… to click A follow-on chip is an offer of something new, so a query this turn already ran is suppressed. That is right until it is all of them. The olfactory system offers exactly two — PartsOf and NeuronsPartHere — and when the absence check runs both, which it does to about one welcome-screen answer in three, every chip was suppressed and the reader was left an answer with nothing at all to click (battery WS3, reproduced 1 in 3 in CI on main and in all three prior Qwen runs' absence-escalation path). The chip is still worth offering in that case: it opens the rows themselves, where the prose only summarised them. Only offering it alongside an unasked query is worse, so the unrun queries still win wherever there are any; the run ones are the fallback, not the default. Suite 1,391/1,393. The new test fails without the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-on chip is an offer of something new, so a query this turn already ran is suppressed. That is right until it is all of them. The olfactory system offers exactly two —
PartsOfandNeuronsPartHere— and when the absence check runs both, which it does to about one welcome-screen answer in three, every chip is suppressed and the reader is left an answer with nothing at all to click. This is battery WS3, the single failure onmain's first run after #71; a WS3-only re-run reproduced it 1 in 3, and it is unrelated to that PR — it has been latent since the absence escalation and the chip suppression have coexisted.The chip is still worth offering in that case: it opens the rows themselves, where the prose only summarised them. Only offering it alongside an unasked query is worse, so the unrun queries still win wherever there are any; the run ones are the fallback, not the default.
Suite 1,391/1,393 (two skips), lint clean. The new test fails without the change.