Skip to content

Do not preserve ownership, mode or directory times when syncing #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Robbie1977 merged 1 commit into from
Aug 27, 2026
Merged

Do not preserve ownership, mode or directory times when syncing #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cache-lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,14 @@ cache_rsync_batch() {
src="$1"; dst="$2"; list="$3"; bwlimit="${4:-0}"; tmpdir="${5:-}"
# --files-from implies --relative, so `a/bc/<hash>` lands at the same
# levels path under <dst> and the intermediate directories are created.
set -- -a --whole-file --update --modify-window="$CACHE_MODIFY_WINDOW" \
# Not -a: no -o/-g/-p and no directory times. The archive is NFS, the
# copying user (nginx) does not own the directories another instance or
# the initial seed created there, and chown/chgrp/chmod/utimes on them
# fail with EPERM (exit 23) on every run. Ownership and mode on the
# destination are irrelevant: rsync creates each file as the copying user
# and nginx only ever reads its own local copy. File mtimes (-t) are kept
# because --update and the backup's find -newer rely on them.
set -- -rltD --omit-dir-times --whole-file --update --modify-window="$CACHE_MODIFY_WINDOW" \
--files-from="$list" --quiet
if [ -n "$tmpdir" ]; then
mkdir -p "$tmpdir"
Expand Down
Loading