Fix for warning message that spam on windows bash 5.3 only - #572
Merged
Merged
Conversation
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
drewgilliam
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
[[ foo =~ '' ]]on windows bash 5.3 generates an error message. This should silence the error and get the result we want.Background
This compatibility check was originally added for macos's bash. This is checking if the regex module that bash was compiled against support empty string and non-literal escape codes. This compatibility is a function of the regex not a function of bash or bash version. So it must be checked to detect it. Previous to bash 5.3, it always just silently returns exit code 2. However on windows, it starts spewing out an warning message. I suspect it's a new behavior in bash 5.3 and not a change in the regex module.
The core behavior hasn't changed, so the logic is still good, I just need to hide the error message. This will never show up on macos, because they will be forever bash 3.2.