Add support for all header types#2
Open
dmorn wants to merge 6 commits into
Open
Conversation
Author
|
@Gazler @taylorbollman are you still maintaining this library? 😇 |
Contributor
|
I'm afraid I no longer have write access to this repo.
…On Mon, 31 Jul 2023, 13:21 Daniel Morandini, ***@***.***> wrote:
@Gazler <https://github.com/Gazler> @taylorbollman
<https://github.com/taylorbollman> are you still maintaining this
library? 😇
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADUSR43SZ244KO6TZB6YATXS6PMFANCNFSM6AAAAAAYQG6BPU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Author
|
@Gazler thanks for answering. Is there anything we can do about it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to specify the header type of each header, supporting
all possible header types. Test coverage is not great, but it has already encoded tons
of AWS Transcribe payloads. I'm happy to help improving the coverage if you're interested
in the contribution.