You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi @jgaleotti. I had a question about this following pr, where the idea was to implement the DTO passage, and the point 5 that Andrea requested:
Create E2E tests for it
Find an open-source project using JSON PATCH (ideally in Java or Kotlin, alternatively Python or JS). On GitHub, searching for “"application/json-patch+json" language:java” yields few results… looking at those, a viable example could be: https://github.com/cassiomolin/http-patch-spring
Another one could be: https://github.com/cjmalloy/jasper
Looking at the two examples, the one at https://github.com/cassiomolin/http-patch-spring is shorter and more concise: I went with that one, but what I wanted to verify is whether I should copy part of that API and create an E2E application with it, or if I should add it to the EMB.
I leave this question here for our meeting, ty!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pr we fix the TO-DO on json patch dtoWritter, and add a slice of the api https://github.com/cassiomolin/http-patch-spring, for e2e testing.