Fix controller rotation authentication handling - #451
Merged
kentbull merged 1 commit intoJul 21, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 88.02% 88.24% +0.22%
==========================================
Files 26 26
Lines 5929 5931 +2
==========================================
+ Hits 5219 5234 +15
+ Misses 710 697 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
iFergal
approved these changes
Jul 21, 2026
Treat SignedHeaderAuthenticator.inbound() as validate-or-raise in the agent rotation handler. Successful signed requests now continue after a normal return, while authentication and malformed-header errors are translated to the existing forbidden response.
kentbull
force-pushed
the
fix/controller-rotation-authentication-contract
branch
from
July 21, 2026 16:02
460ecfe to
ba5001d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #351.
Treat
SignedHeaderAuthenticator.inbound()as validate-or-raise in the agent rotation handler, translating authentication failures to the existing 403 response.Tests:
uv run pytest -q tests/(76 passed).