Skip to content

Handle untargeted ACDCs in IPEX Grant artifact gathering - #453

Merged
kentbull merged 1 commit into
WebOfTrust:mainfrom
kentbull:fix/untargeted-ipex-grant
Jul 23, 2026
Merged

Handle untargeted ACDCs in IPEX Grant artifact gathering#453
kentbull merged 1 commit into
WebOfTrust:mainfrom
kentbull:fix/untargeted-ipex-grant

Conversation

@kentbull

Copy link
Copy Markdown
Collaborator

Fixes #452 crash on untargeted ACDC or missing issuee

Skip issuee KEL and delegation artifact gathering when an ACDC has no disclosed issuee, including compact attribute sections. Issuer, delegated issuer/issuee, registry, and credential TEL gathering remain intact.

Adds direct unit coverage for every branch of gatherArtifacts() and verifies the existing SignifyPy untargeted-IPEX flow end to end.

@kentbull
kentbull force-pushed the fix/untargeted-ipex-grant branch from 3cb1f9e to f9a5029 Compare July 21, 2026 21:19
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (ba5001d) to head (b5d8e64).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   88.24%   88.44%   +0.19%     
==========================================
  Files          26       26              
  Lines        5931     5938       +7     
==========================================
+ Hits         5234     5252      +18     
+ Misses        697      686      -11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kentbull
kentbull force-pushed the fix/untargeted-ipex-grant branch from f9a5029 to b5d8e64 Compare July 23, 2026 13:10
@kentbull
kentbull requested a review from iFergal July 23, 2026 13:52

@iFergal iFergal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

Comment thread tests/app/test_ipexing.py
@kentbull
kentbull merged commit 86e21cb into WebOfTrust:main Jul 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPEX Grant crashes on untargeted ACDCs without an issuee

2 participants