test pr - #1
Closed
chendelin1982 wants to merge 1 commit into
Closed
Conversation
Comment on lines
89
to
90
| - Docker: TBD | ||
| - Kubernetes: TBD | ||
| - Cloud Providers: TBD |
There was a problem hiding this comment.
After removing the Kubernetes line, the list formatting appears inconsistent. The "- Docker: TBD" and "- Cloud Providers: TBD" lines should maintain proper bullet list formatting with consistent indentation. Please verify that the resulting markdown renders correctly as a proper bullet list.
chendelin1982
commented
Jan 7, 2026
chendelin1982
left a comment
chendelin1982
left a comment
Contributor
Author
There was a problem hiding this comment.
I try to read it
Comment on lines
89
to
90
| - Docker: TBD | ||
| - Kubernetes: TBD | ||
| - Cloud Providers: TBD |
There was a problem hiding this comment.
The removal of the Kubernetes line has created an inconsistent list format. The "Production Deployment" section now has:
- Docker: TBD (prefixed with "- ")
- Cloud Providers: TBD (prefixed with "- ")
However, the original had a nested structure where Kubernetes was indented. If Kubernetes deployment is no longer planned, this is fine, but ensure the remaining items follow consistent markdown list formatting with proper "- " prefixes for all list items.
chendelin1982
pushed a commit
that referenced
this pull request
Jan 21, 2026
…8 CLI generate Story 1.17: Platform Initialization - Add InitConfig for super admin account configuration (username, email, password) - Implement GetOrCreateSuperAdmin with random password generation - Auto-assign platform_admin role to super admin - Create Platform Project with fixed UUID (00000000-0000-0000-0000-000000000000) - Add reserved username protection (admin, root, administrator, etc.) - Add beautiful console output for generated credentials - Update bootstrap/server.go to initialize platform on startup - Add comprehensive test coverage for initialization logic Story 1.18: CLI Generate - Unified Code Generation - Refactor 3-4-config-example-generator into unified CLI generate command - Move from scripts/generate-config-example.go to cmd/generate.go - Add generator interface in modules/config/generator.go (600+ lines) - Support envonly tag for operational settings (AUTO_INIT, etc.) - Generate both config.example and .env.example - Add generate model (Ent ORM) and generate openapi subcommands - Update Makefile to use new CLI command - Move Story 3.4 to Story 1.18, expand scope to unified generation Refactoring & Optimization: - Rename SuperAdminConfig → InitConfig for better semantics - Move PlatformProject constants to auth/config.go - Add bootstrap/config.go for operational settings (AUTO_INIT) - Add password/generator.go for secure random password generation - Fix golangci-lint warnings (defer error handling, unused variables) - Update all documentation references and file paths Documentation: - Create docs/sprint-artifacts/sprint-1/1-18-cli-generate.md - Update 1-infrastructure-epic.md (add Story 1.18, 79% progress) - Update 3-config-epic.md (move Story 3.4, mark as completed) - Update cli-reference.md with generate command documentation - Update coding-standards.md with envonly tag explanation - Update Story 1.17, 3.2, 3.3, 5.1, 5.5 acceptance criteria Breaking Changes: - Configuration structure change: auth.super_admin → auth.init - Removed scripts/generate-config-example.go (replaced by CLI command) - Users must update default.yaml if customizing super admin settings Related Stories: #1.17, #1.18, #3.4, #5.1, #5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.