fix: imhex uses all memory#239
Merged
Merged
Conversation
The issue is caused by loops like the following
```cpp
while (!sequence(tkn::Separator::RightBrace)) {
auto statement = parseFunctionStatement();
if (statement == nullptr)
continue;
body.push_back(std::move(statement));
}
```
so that if the function does nor advance the token pointer, the loop never ends even if errors are generated. Some of these loops solve that by calling
```cpp
if (hasErrors())
break;
```
in which case generating errors is enough to avoid the problem. In this fix I changed all potentially exploding loops to check for errors and I tested the result with all the types of variables that use the loops like try/catch, unions, conditionals, match statements , ... and the problem seems resolve for good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is caused by loops like the following
so that if the function does nor advance the token pointer, the loop never ends even if errors are generated. Some of these loops solve that by calling
in which case generating errors is enough to avoid the problem. In this fix I changed all potentially exploding loops to check for errors and I tested the result with all the types of variables that use the loops like try/catch, unions, conditionals, match statements , ... and the problem seems resolve for good.