fix: imhex uses all memory#240
Merged
Merged
Conversation
It appears that my attempt to patch all possible places that could create an infinite loop failed to notice cases like namespace parsing and possibly others. Being unable to guarantee that the error alone will stop the loops I am forced to also make sure that every result of the loop advances the cursor at least one token. I can't really say if this is going to finally fix this problem but just as before, all tests I ran showed that it is indeed the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that my attempt to patch all possible places that could create an infinite loop failed to notice cases like namespace parsing and possibly others. Being unable to guarantee that the error alone will stop the loops I am forced to also make sure that every result of the loop advances the cursor at least one token. I can't really say if this is going to finally fix this problem but just as before, all tests I ran showed that it is indeed the case.