Skip to content

feat: add P1 conditional visual review evidence - #286

Merged
Wibias merged 1 commit into
feat/p1-pr-consolidationfrom
feat/p1-visual-evidence
Aug 18, 2026
Merged

feat: add P1 conditional visual review evidence#286
Wibias merged 1 commit into
feat/p1-pr-consolidationfrom
feat/p1-visual-evidence

Conversation

@Wibias

@Wibias Wibias commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • add deterministic detection of UI/render-surface changes that require visual evidence
  • integrate the visual-evidence plan directly into review-scope rather than creating a separate approval workflow
  • require screenshot/video/render artifacts to be bound to the current head SHA
  • reject stale artifacts and text-only claims as visual evidence
  • preserve honest runtime/tool blockers as blocked, never as a clean visual verdict
  • avoid forcing product screenshots for arbitrary backend TypeScript or documentation-only image changes

Hardening found during self-review

  • visual assets renamed from docs into product paths now require visual evidence
  • visual assets renamed out of product paths also retain evidence requirements for the removed product-side surface
  • the detector now evaluates each visual path independently instead of letting one docs path suppress a product path during renames
  • the visual slice remains exactly five changed files after restacking parent fixes

Stack

Validation

  • focused contracts cover stylesheet/UI triggers, backend/doc non-triggers, docs/product asset renames, stale-head rejection, blocker semantics, and review-scope integration
  • repository-wide local suite is intentionally left to the user's local run; GitHub Actions is not used as the current gate

Provenance

The direction was informed by OutThisLife/brooklyn-skills visual-verify and implemented as a conditional evidence axis inside GitHub Delivery's existing review architecture.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a356606-e8ac-46b0-8d17-be57e20b0038

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias force-pushed the feat/p1-visual-evidence branch from c98b7e4 to 2f8caad Compare August 18, 2026 05:51
@Wibias
Wibias marked this pull request as ready for review August 18, 2026 07:46
@Wibias
Wibias force-pushed the feat/p1-visual-evidence branch from 2f8caad to f979c95 Compare August 18, 2026 07:58
@Wibias
Wibias force-pushed the feat/p1-visual-evidence branch from f979c95 to 0e48a72 Compare August 18, 2026 08:04
@Wibias
Wibias merged commit 165c5a7 into main Aug 18, 2026
10 checks passed
@Wibias
Wibias deleted the feat/p1-visual-evidence branch August 18, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant