Skip to content

Replace text artwork actions with icons #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keks2293 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace text artwork actions with icons #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions app/src/main/feature/library/GameSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ import androidx.compose.material.icons.outlined.Check
import androidx.compose.material.icons.outlined.Close
import androidx.compose.material.icons.outlined.Home
import androidx.compose.material.icons.outlined.Inventory
import androidx.compose.material.icons.outlined.Image
import androidx.compose.material.icons.outlined.KeyboardArrowDown
import androidx.compose.material.icons.outlined.CloudOff
import androidx.compose.material.icons.outlined.Search
Expand Down Expand Up @@ -1069,7 +1070,7 @@ private fun GeneralSection(
) {
@Composable
fun ActionButton(
text: String,
icon: ImageVector,
tint: Color,
onClick: () -> Unit,
) {
Expand All @@ -1082,11 +1083,11 @@ private fun GeneralSection(
.clickable { onClick() }
.padding(horizontal = 10.dp, vertical = 6.dp)
) {
Text(
text = text,
color = tint,
fontSize = SettingLabelSize,
fontWeight = FontWeight.Medium
Icon(
imageVector = icon,
contentDescription = null,
tint = tint,
modifier = Modifier.size(SettingIconSize)
)
}
}
Expand Down Expand Up @@ -1133,15 +1134,15 @@ private fun GeneralSection(
) {
if (!selected) {
ActionButton(
text = stringResource(R.string.shortcuts_library_artwork_set),
icon = Icons.Outlined.Image,
tint = AccentBlue,
onClick = onPick
)
}

if (selected) {
ActionButton(
text = stringResource(R.string.common_ui_remove),
icon = Icons.Outlined.Delete,
tint = DangerRed,
onClick = onRemove
)
Expand Down