Tests: Add missing @covers tags for blocks, oembed, and rewrite tests#11532
Open
sagarsdeshmukh wants to merge 1 commit intoWordPress:trunkfrom
Open
Tests: Add missing @covers tags for blocks, oembed, and rewrite tests#11532sagarsdeshmukh wants to merge 1 commit intoWordPress:trunkfrom
sagarsdeshmukh wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Follow-up to [62213], [62218], [62222]. See #64225.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds missing
@coversannotations to 10 test classes across theblocks,oembed, andrewritegroups, as part of the ongoing effort in #64225.blocks/
render.php@covers ::do_blocksrenderReusable.php@covers WP_BlockwpBlockParser.php@covers WP_Block_ParserwpBlockList.php@covers WP_Block_ListregisterBlockTypeFromMetadataWithRegistry.php@covers ::register_block_type_from_metadataoembed/
wpOembed.php@covers WP_oEmbedWpEmbed.php@covers WP_EmbedpostEmbedUrl.php@covers ::get_post_embed_urlrewrite/
permastructs.php@covers ::add_permastruct,@covers ::remove_permastructnumericSlugs.php@covers ::url_to_postidWhy
Without
@covers, PHPUnit cannot correctly attribute code coverage to the functions and classes under test. This leads to inaccurate coverage reports on Codecov, where a function may appear uncovered even when dedicated tests exist for it.Testing
Ran all 10 affected test classes locally:
Trac
Follow-up to [62213], [62218], [62222].
Fixes https://core.trac.wordpress.org/ticket/64225