Fix diesel_logger compilation error - #381
Open
Inertia-Squared wants to merge 1 commit into
Open
Conversation
Author
|
There is an open PR in the diesel_logger repo which would also resolve this. If we don't want to pin the version I could fork and publish an updated version of diesel_logger so that the project is compatible with the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick and dirty fix for latest diesel versions (noted on 2.3.12 but may break earlier) being incompatible with diesel_logger v0.4.0.
I found the issue is similar to one submitted previously, and was able to resolve by pinning to Minor version 2.2.X.
Might look into submitting a patch to make diesel_logger compatible, but haven't really looked to see what that would require, so I thought I'd get a quick fix out first so the cli tool works in a default configuration!