Conversation
…rmalization Two bugs behind framework frames (node_modules/next/...) outranking real app frames as the "suspect"/"crashed in" frame: 1. StackTrace.tsx and IssueDetail.tsx SuspectFrame picked a frame by contextLine/usable-path availability before exhausting in-app options — an in-app frame can resolve inApp:true with contextLine:undefined (its chunk's map lacked sourcesContent) while an unrelated framework frame from a different chunk resolves with full context, wrongly winning. 2. apply-map.ts's FRAMEWORK_INTERNAL_RE has an anchored `^src/...` alternative for Next-internal files that resolve without a node_modules segment; Turbopack's unstripped turbopack:///[project]/ prefix broke that anchor. New packages/shared/src/frames.ts (normalizeFramePath + pickSuspectFrame) is the single source of truth, replacing 5 duplicated/inconsistent path-stripping and frame-selection implementations across workers + web (also fixes agentMarkdown.ts's outermost-first pick and GitHub deep-link building for Turbopack paths). FR-MAP-5/FR-GRP-3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rmalization
Two bugs behind framework frames (node_modules/next/...) outranking real app frames as the "suspect"/"crashed in" frame:
^src/...alternative for Next-internal files that resolve without a node_modules segment; Turbopack's unstripped turbopack:///[project]/ prefix broke that anchor.New packages/shared/src/frames.ts (normalizeFramePath + pickSuspectFrame) is the single source of truth, replacing 5 duplicated/inconsistent path-stripping and frame-selection implementations across workers + web (also fixes agentMarkdown.ts's outermost-first pick and GitHub deep-link building for Turbopack paths). FR-MAP-5/FR-GRP-3.