fix(session): use idle framing when a checkpoint rebuild follows a completed stop - #2061
Open
YOMXXX wants to merge 1 commit into
Open
fix(session): use idle framing when a checkpoint rebuild follows a completed stop#2061YOMXXX wants to merge 1 commit into
YOMXXX wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1915 (part 1). After a finite task completes, a checkpoint rebuild unconditionally reinjected "Pick up the last task as if the break never happened" plus resume reminders, so the main agent re-verified already-finished work → token growth → repeated writers/rebuilds → keep-alive loop.
Root cause:
packages/opencode/src/session/checkpoint.tsrenderRebuildContext()Section 10 always appended the hard resume text, and Section 11 used a resume-orientedstopReminder()forassistant+finish === "stop". No idle/done branch.Fix: gate the resume framing on the tail:
done = lastMessageInfo?.role === "assistant" && lastMessageInfo.finish === "stop".assistant/stop→ newidleReminder()(do-not-reopen + progress.md guidance so a genuinely mid-task / truncated / cancelled agent still knows where to judge);tool-calls→autonomousLoopReminder()(unchanged);tool→toolResultContinueReminder()(unchanged).stopReminder.Test Plan
assistant/stop→ no "Pick up the last task", contains "wait for the user";assistant/tool-calls→ keeps resume framing.checkpoint-rebuild-v3.test.ts(its old assertion referenced the removedstopRemindertext).bun test test/session/checkpoint-render-verify.test.ts test/session/checkpoint-rebuild-v3.test.ts— 22 pass;bun typecheckclean.Notes