fix(session): cap per-message summary diff size to prevent OOM bloat - #2062
Open
YOMXXX wants to merge 1 commit into
Open
fix(session): cap per-message summary diff size to prevent OOM bloat#2062YOMXXX wants to merge 1 commit into
YOMXXX wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1854 (part of it).
message.summary.diffsgrow unbounded — single messages reach tens–hundreds of MB becauseSnapshot.FileDiff.patchholds the full file content (diffFull uses full context). On resume, JSON → V8 heap ×copies → 10–20 GB process commit → OOM / Windows Event 2004.Root cause:
packages/opencode/src/session/summary.tssummarize()stores the full per-message diff into the message summary with no size cap.Fix: cap the per-message summary diff at
MAX_SUMMARY_DIFF_BYTES(1 MB):capSummaryDiffs()slices eachFileDiff.patchto the remaining byte budget and drops entries once exhausted, so a single huge patch can never bloat a message beyond ~1 MB.session_diff) and the revert path are untouched — they use the unbounded diff.Test Plan
bun test test/session/summary-diffs-cap.test.ts— 3 pass; full session suite 913 pass no regression.bun typecheck— clean.Notes
messageID-scoped diff API returns truncated (structurally-invalid) diffs for huge single-file edits. No in-repo consumer uses the messageID variant (the TUI uses the session-level diff); the cap solves the OOM at the cost of per-message diff fidelity for pathological edits.