refactor: translate logFormat from string type to enum - #2167
Closed
MiMoHardFather wants to merge 1 commit into
Closed
refactor: translate logFormat from string type to enum#2167MiMoHardFather wants to merge 1 commit into
MiMoHardFather wants to merge 1 commit into
Conversation
Replaces the opaque string-based LogFormat with a proper enum-based export, making tool visibility logic self-documenting and type-safe. - Extract LogFormat enum to tool-visibility.ts as public export - Remove duplicate LogFormat enum from session/index.tsx - Replace magic strings with LogFormat.BRIEF/FULL values - Add tests for enum round-trip and comparison consistency - Update docs with LogFormat enum and language-agnostic design Closes #80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the opaque string-based LogFormat with a proper enum-based export, making tool visibility logic self-documenting and type-safe.
Closes #80