fix: remove skill search reminders and related infrastructure - #2168
Merged
Conversation
Remove skill_search_reminder feature that produced false-positive skill discoveries. The reminders inserted .mimo/ subagent guidance and tool use guidance into assistant text for irrelevant tasks. Changes: - Delete skill-search-reminder.ts and its tests - Remove Flag.SKILL_SEARCH_REMINDER and its tests - Remove both guidance strings from all provider prompts - Remove MI_NO_SKILL_SEARCH_REMINDER docs - Remove skill_search_references_tools from registry tests - Remove empty ext/ directory The skill_search tool and behavior remain functional without reminders. Add .nul.txt to .gitignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove skill_search_reminder feature that produced false-positive skill discoveries. The reminders inserted .mimo/ subagent guidance and tool use guidance into assistant text for irrelevant tasks.
Changes:
The skill_search tool and behavior remain functional without reminders. Add .nul.txt to .gitignore.
Issue / context (if applicable)
Type of change
Bug fix / New feature / Refactor / Documentation — keep the ones that apply and delete the rest.
What does this PR do?
Briefly describe the problem, what changed, and why this approach works.
How did you verify your code works?
What did you test, and how can a reviewer reproduce the result?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist