Feat/capability receipt - #2185
Open
yuyang27 wants to merge 2 commits into
Open
Conversation
yuyang27
force-pushed
the
feat/capability-receipt
branch
2 times, most recently
from
August 22, 2026 04:00
83c9d8b to
41d005c
Compare
…E-1) Emit what THIS step actually loaded — active tools + model-reachable skills + a stable hash — on the step-start message part, so the desktop host can trust the engine's receipt instead of deriving 'available' from install state. Two halves because skills are not tools: the tool table only ever holds a generic skill/skill_search, while the real skill list is injected into the system prompt. tools = resolveTools' activeTools (callable this turn); skills = Skill.modelInvocable (permission- + disable_model_invocation-filtered), reused via new SystemPrompt.skillNames. Carried prompt.ts -> StreamInput -> processor ctx -> step-start part; max-mode replay forwards it too.
Unit-tests SystemPrompt.skillNames (the receipt's skills[] source): excludes disable-model-invocation skills and returns empty when the skill tool is permission-denied — the invariant that skills[] matches model reachability, not the broader available/all sets. (A full-turn integration test that spawned a real engine to assert the receipt reaches the step-start part was dropped: its provideTmpdirServer spawn added ~100s of concurrent load to its CI shard, tipping timing-sensitive workflow worktree/fan-out tests past their deadlines. The receipt→step-start wiring is plain and covered end-to-end by the desktop-side e2e.)
yuyang27
force-pushed
the
feat/capability-receipt
branch
from
August 22, 2026 04:13
41d005c to
69261f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue / context (if applicable)
Type of change
Bug fix / New feature / Refactor / Documentation — keep the ones that apply and delete the rest.
What does this PR do?
Briefly describe the problem, what changed, and why this approach works.
How did you verify your code works?
What did you test, and how can a reviewer reproduce the result?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist