Skip to content

Restricting the use of JSON file input to only apply to non-escalated processes #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvillarre merged 1 commit into from
Jul 20, 2026
Merged

Restricting the use of JSON file input to only apply to non-escalated processes #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion profile/plugin/aie_profile/aie_profile_metadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ namespace xdp {
std::string settingFile = xrt_core::config::get_xdp_json();
PluginJsonSetting pluginSettings;

if (!settingFile.empty() && SettingsJsonParser::getInstance().isValidJson(settingFile)) {
// Only check for JSON file as an input if not running as root
if (!xrt_core::utils::is_elevated_process() &&
!settingFile.empty() &&
SettingsJsonParser::getInstance().isValidJson(settingFile)) {
xrt_core::message::send(severity_level::info, "XRT",
"Using JSON settings from '" + settingFile + "'");

Expand Down
7 changes: 5 additions & 2 deletions profile/plugin/aie_trace/aie_trace_metadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,11 @@ namespace xdp {
bool useXdpJson = false;
std::string settingFile = xrt_core::config::get_xdp_json();
PluginJsonSetting pluginSettings;

if (!settingFile.empty() && SettingsJsonParser::getInstance().isValidJson(settingFile)) {

// Only use the JSON file if we aren't running as root
if (!xrt_core::utils::is_elevated_process() &&
!settingFile.empty() &&
SettingsJsonParser::getInstance().isValidJson(settingFile)) {
xrt_core::message::send(severity_level::info, "XRT",
"Using JSON settings from '" + settingFile + "'");

Expand Down
Loading