Log nBytes of trace only for plio#92
Merged
Merged
Conversation
Signed-off-by: predutta <predutta@amd.com>
jvillarre
approved these changes
Jul 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts how AIE trace offload data is forwarded to the trace logger by changing the copy behavior when adding trace buffers, intending to special-case PLIO-related trace handling.
Changes:
- Updated
AIETraceOffload::syncAndLog()to passmEnCircularBuf || isPLIOas thecopyflag totraceLogger->addAIETraceData(...)instead of always copying.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
418
to
+420
| // Log nBytes of trace. Always copy: syncTraceBuf() unmaps the BO before returning. | ||
| traceLogger->addAIETraceData(index, hostBuf, nBytes, true); | ||
|
|
||
| traceLogger->addAIETraceData(index, hostBuf, nBytes, mEnCircularBuf || isPLIO); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling logging of the trace only for plio.
Tested on aie2 (vek280) plio design that was failing earlier.