Skip to content

Increase default ML Timeline debug buffer size and add new ML_timeline_settings.buffer_config#9925

Open
IshitaGhosh wants to merge 2 commits into
Xilinx:masterfrom
IshitaGhosh:dbgBf
Open

Increase default ML Timeline debug buffer size and add new ML_timeline_settings.buffer_config#9925
IshitaGhosh wants to merge 2 commits into
Xilinx:masterfrom
IshitaGhosh:dbgBf

Conversation

@IshitaGhosh

@IshitaGhosh IshitaGhosh commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Problem solved by the commit

  1. Increase default size of ML Timeline debug buffer to capture more data without overwriting
  2. Introduce ML_timeline_settings.buffer_config to accept ML Timeline debug buffer configuration with shim column, index of uC
  3. Remove ML_timeline_settings.num_buffer_segments config in xrt.ini

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

https://jira.xilinx.com/browse/AIESW-39288

How problem was solved, alternative solutions (if any) and why they were rejected

Input config info from user

Risks (if any) associated the changes in the commit

What has been tested and how, request additional testing if necessary

Unit test

Documentation impact (if any)

…e_settings.buffer_config

Signed-off-by: Ishita Ghosh <ishitag@amd.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

get_ml_timeline_settings_buffer_config()
{
static unsigned int value = detail::get_uint_value("ML_timeline_settings.num_buffer_segments", 0);
static unsigned int value = detail::get_uint_value("ML_timeline_settings.buffer_config", "");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: cannot initialize a parameter of type 'unsigned int' with an lvalue of type 'const char[1]' [clang-diagnostic-error]

  static unsigned int value = detail::get_uint_value("ML_timeline_settings.buffer_config", "");
                                                                                           ^
Additional context

src/runtime_src/core/common/config_reader.h:73: passing argument to parameter here

get_uint_value(const char*, unsigned int);
                                        ^

{
static unsigned int value = detail::get_uint_value("ML_timeline_settings.num_buffer_segments", 0);
static unsigned int value = detail::get_uint_value("ML_timeline_settings.buffer_config", "");
return value;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: no viable conversion from returned value of type 'unsigned int' to function return type 'std::string' (aka 'basic_string') [clang-diagnostic-error]

  return value;
         ^
Additional context

/usr/include/c++/13/bits/basic_string.h:546: candidate constructor not viable: no known conversion from 'unsigned int' to 'const basic_string &' for 1st argument

      basic_string(const basic_string& __str)
      ^

/usr/include/c++/13/bits/basic_string.h:640: candidate constructor template not viable: no known conversion from 'unsigned int' to 'const char *' for 1st argument

      basic_string(const _CharT* __s, const _Alloc& __a = _Alloc())
      ^

/usr/include/c++/13/bits/basic_string.h:676: candidate constructor not viable: no known conversion from 'unsigned int' to 'basic_string &&' for 1st argument

      basic_string(basic_string&& __str) noexcept
      ^

/usr/include/c++/13/bits/basic_string.h:705: candidate constructor not viable: no known conversion from 'unsigned int' to 'initializer_list' for 1st argument

      basic_string(initializer_list<_CharT> __l, const _Alloc& __a = _Alloc())
      ^

/usr/include/c++/13/bits/basic_string.h:534: explicit constructor is not a candidate

      basic_string(const _Alloc& __a) _GLIBCXX_NOEXCEPT
      ^

/usr/include/c++/13/bits/basic_string.h:794: explicit constructor is not a candidate

	basic_string(const _Tp& __t, const _Alloc& __a = _Alloc())
 ^

…e_settings.buffer_config

Signed-off-by: Ishita Ghosh <ishitag@amd.com>
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant