[XRT-SMI] Update TCT tests to follow different logic from strix and report throughpuy#9927
Open
aktondak wants to merge 2 commits into
Open
[XRT-SMI] Update TCT tests to follow different logic from strix and report throughpuy#9927aktondak wants to merge 2 commits into
aktondak wants to merge 2 commits into
Conversation
Signed-off-by: Akshay Tondak <aktondak@amd.com>
Signed-off-by: Akshay Tondak <aktondak@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
The TCT validate tests did not handle MDS (NPU3) correctly: they assumed fixed Strix token counts when computing latency and throughput. This change adds an MDS path that uses runner elapsed time and iteration count, keeps Strix behavior unchanged, and shares a common workload runner between both platforms. Separately, xrt-smi watch mode now refreshes the terminal on each step for snapshot-style reports (examine, context-health), while firmware-log and event-trace streaming watch modes are unchanged. The shim also maps firmware log configure failures to a clear “Invalid firmware log level” message.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
TCT tests use one run_tct_workload() path and branch only in calculate_tct_metrics() (Strix uses fixed samples × iterations; MDS uses iterations only). We rejected duplicating full Strix/MDS run functions and using the runner’s precomputed latency/throughput fields, which do not match the MDS workload model. Watch mode defaults refresh_terminal to true, with firmware-log and event-trace explicitly opting out.
Risks (if any) associated the changes in the commit
The reported TCT numbers would now change
What has been tested and how, request additional testing if necessary
Tested on npu3 platform. This TCT throughput seems close to no-op throughput so numbers make more sense now :
Documentation impact (if any)
None