Update webview2 version to 145. New Github Actions - #58
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates WinFormedge’s dependencies and CI publishing flow by bumping WebView2 (and related versioning) and introducing an OIDC-based NuGet authentication step in GitHub Actions.
Changes:
- Bump
Microsoft.Web.WebView2to1.0.3800.47andMicrosoft.Windows.CsWin32to0.3.298. - Update WinFormedge package versioning to align with the new WebView2 build and bump Release version to
1.1.2. - Switch NuGet publishing workflow to use
NuGet/login@v1to obtain a temporary API key (OIDC) instead of a stored API key secret.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/WinFormedge/WinFormedge.csproj | Updates WebView2/CsWin32 package versions and bumps package version metadata. |
| .github/workflows/dotnet-desktop.yml | Adds NuGet OIDC login step and uses the emitted temp API key for package push. |
Comments suppressed due to low confidence (1)
.github/workflows/dotnet-desktop.yml:5
- NuGet/login uses GitHub OIDC; without explicitly granting
id-token: writepermissions, this step commonly fails to mint a token (depending on repo/org default permissions). Add an explicitpermissionsblock so the OIDC-based login is reliable.
name: Build and Publish
on:
push:
branches: [master]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.