Skip to content

Update webview2 version to 145. New Github Actions - #58

Merged
XuanchenLin merged 1 commit into
masterfrom
dev
Jul 14, 2026
Merged

XuanchenLin merged 1 commit into
masterfrom
dev

Conversation

@XuanchenLin

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 14, 2026 13:42
@XuanchenLin
XuanchenLin merged commit b1f371a into master Jul 14, 2026
1 check passed
@XuanchenLin
XuanchenLin deleted the dev branch July 14, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates WinFormedge’s dependencies and CI publishing flow by bumping WebView2 (and related versioning) and introducing an OIDC-based NuGet authentication step in GitHub Actions.

Changes:

  • Bump Microsoft.Web.WebView2 to 1.0.3800.47 and Microsoft.Windows.CsWin32 to 0.3.298.
  • Update WinFormedge package versioning to align with the new WebView2 build and bump Release version to 1.1.2.
  • Switch NuGet publishing workflow to use NuGet/login@v1 to obtain a temporary API key (OIDC) instead of a stored API key secret.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/WinFormedge/WinFormedge.csproj Updates WebView2/CsWin32 package versions and bumps package version metadata.
.github/workflows/dotnet-desktop.yml Adds NuGet OIDC login step and uses the emitted temp API key for package push.
Comments suppressed due to low confidence (1)

.github/workflows/dotnet-desktop.yml:5

  • NuGet/login uses GitHub OIDC; without explicitly granting id-token: write permissions, this step commonly fails to mint a token (depending on repo/org default permissions). Add an explicit permissions block so the OIDC-based login is reliable.
name: Build and Publish

on:
  push:
    branches: [master]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants