Remove reference member from ChunkPointer#32
Open
Baryonics wants to merge 2 commits into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Baryonics
force-pushed
the
reader_remove_reference_member
branch
from
8dbcc65 to
07688a2
Compare
YanzhaoW
reviewed
May 19, 2026
Owner
YanzhaoW
left a comment
YanzhaoW
left a comment
There was a problem hiding this comment.
Hi,
thanks for the PR. Just a little bit improvement on the name.
| .transform( | ||
| [&size](auto) | ||
| { | ||
| ++size; |
Owner
There was a problem hiding this comment.
I feel size is a bad name, and it isn't concrete about which size it represents. Maybe use current_n_points?
Owner
|
Ok, good. Squash it and I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::size_t ¤t_sizefromChunkPointerchunk_end_after_increment()accordinglyparse_entry_points()incrementssize_via lambdaFixes #31