Add exact_bbox_output mode to build_subchunkable_apply_flow#1207
Open
supersergiy wants to merge 1 commit into
Open
Add exact_bbox_output mode to build_subchunkable_apply_flow#1207supersergiy wants to merge 1 commit into
supersergiy wants to merge 1 commit into
Conversation
supersergiy
force-pushed
the
sergiy/exact-bbox-output
branch
2 times, most recently
from
992b619 to
2677550
Compare
Writes exactly the user-requested bbox without expanding or destroying surrounding data. Processing uses the expanded bbox internally with intermediaries; only the original bbox is copied to the final dst, using read-modify-write for edge chunks. CVBackend.with_changes now reconstructs InfoSpecParams from the existing info file when the caller mutates voxel_offset / chunk_size / dataset_size on an info_path-only spec, so layers opened without info_scales can be used as the dst for intermediary creation. The deprecated CVBackend gains overwrite_partial_chunks parity with the modern backend so old version-pinned specs reach the new branch.
supersergiy
force-pushed
the
sergiy/exact-bbox-output
branch
from
2677550 to
8feb3f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
========================================
Coverage 99.98% 99.98%
========================================
Files 196 205 +9
Lines 10491 10700 +209
========================================
+ Hits 10489 10698 +209
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Can you fix the conflict please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exact_bbox_outputparameter for writing exactly the user's bbox without expanding or destroying surrounding dataPrecomputedInfoSpec.to_mutable()enables intermediary creation on layers opened withoutinfo_scalessmart_copynow usesexact_bbox_output=True