Skip to content

[Fix] Review Roomote pull requests with CodeRabbit - #1598

Draft
zoomote[bot] wants to merge 2 commits into
mainfrom
fix/enable-coderabbit-for-zoomote-3sg5r1hbj93nu
Draft

[Fix] Review Roomote pull requests with CodeRabbit#1598
zoomote[bot] wants to merge 2 commits into
mainfrom
fix/enable-coderabbit-for-zoomote-3sg5r1hbj93nu

Conversation

@zoomote

@zoomote zoomote Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Treat zoomote[bot] as eligible for the existing CodeRabbit review path.
  • Apply coderabbit-review-active only after the PR is ready and required CI passes, matching human-authored PR behavior.
  • Preserve the direct-to-maintainer path for all other bot authors.
  • Add focused coverage for successful activation, draft PRs, failing required CI, unrelated bots, and the corresponding coderabbit=pending / coderabbit=optional diagnostics.

Why this change was made

Roomote-authored PRs were classified with every other bot and skipped CodeRabbit even when they were otherwise ready for automated review. This narrow exception enables the repository's existing label-driven opt-in without broadening review behavior for Dependabot or other automation.

Impact

Eligible zoomote[bot] PRs now wait for CodeRabbit before maintainer review under the same gates as human PRs. Official CodeRabbit documentation says a configured positive label triggers review even when automatic reviews are disabled and bot accounts are excluded only through ignore_usernames; Zoo does not ignore zoomote[bot]. Existing PR #1584 also reported the missing label as its skip reason, not bot authorship. A live post-merge PR remains the definitive operational verification; if CodeRabbit does not start, a human @coderabbitai review command remains the fallback.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3f492535-ebf9-4731-ad03-51e4264ee075

📥 Commits

Reviewing files that changed from the base of the PR and between 805b817 and 039b1cd.

📒 Files selected for processing (1)
  • src/services/__tests__/pr-review-state-workflow.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: platform-unit-test (windows-latest)
🧰 Additional context used
📓 Path-based instructions (5)
Check persistence and lifecycle invariants: awaited atomic writes, rollback or explicit partial-failure behavior, cross-window state consistency, stale listeners/watchers, cancellation, idempotency, and safe restart/resume without lost or d...

⚙️ CodeRabbit configuration file

Files:

  • src/services/__tests__/pr-review-state-workflow.test.ts
Require regression coverage at the lowest valid harness with behavior-focused assertions, including relevant negative, error, false/unset, and boundary cases.

⚙️ CodeRabbit configuration file

Files:

  • src/services/__tests__/pr-review-state-workflow.test.ts
Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.

⚙️ CodeRabbit configuration file

Files:

  • src/services/__tests__/pr-review-state-workflow.test.ts
Verify extension/webview contracts, cancellation and error propagation, VS Code lifecycle correctness, and behavior under retries and partial failure.

⚙️ CodeRabbit configuration file

Files:

  • src/services/__tests__/pr-review-state-workflow.test.ts
Act as an adversarial second-opinion reviewer.

⚙️ CodeRabbit configuration file

Files:

  • src/services/__tests__/pr-review-state-workflow.test.ts
🔇 Additional comments (1)
src/services/__tests__/pr-review-state-workflow.test.ts (1)

399-399: LGTM!

Also applies to: 550-550, 588-588, 591-593, 610-610


📝 Summary

Summary by CodeRabbit

  • Workflow Updates
    • Pull requests authored by zoomote[bot] now receive required CodeRabbit review after required checks pass.
    • Draft pull requests and pull requests with failing required checks do not start CodeRabbit review.
    • Other bot-authored pull requests continue through the optional-review path and proceed directly to maintainer review.
    • Review status logging now distinguishes pending required reviews from optional reviews.

Walkthrough

The workflow now requires CodeRabbit review for zoomote[bot]. Other bot-authored pull requests remain on the maintainer-review path. Tests cover eligible, draft, failing-CI, and other-bot scenarios.

Changes

Review state routing

Layer / File(s) Summary
CodeRabbit eligibility policy
.github/workflows/label-pr-review-state.yml
The workflow allowlists zoomote[bot], routes eligible authors through required CodeRabbit review, and logs pending or optional states.
Author routing scenarios
src/services/__tests__/pr-review-state-workflow.test.ts
The test harness exposes informational logs. Tests verify CodeRabbit activation for eligible pull requests and maintainer routing for other bot-authored pull requests, including draft and failing-CI cases.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: hannesrudolph

Merge Risk: ⚪ Minimal · up to 039b1

The change enables the intended CodeRabbit flow for zoomote-authored pull requests while preserving the maintainer path for other bots.

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, rationale, scope, and covered scenarios. It does not follow the required template because it omits the Related GitHub Issue section, Test Procedure section, comple… Add the required template sections. Link an approved issue, document exact test commands and verification steps, complete the pre-submission checklist, state whether documentation updates are required, and provide the requested contact info…
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Regression Evidence ✅ Passed The changed workflow behavior has focused coverage at the workflow-script harness layer. Tests cover zoomote[bot] activation after passing CI, draft PRs, failing required CI, and the `coderabbit=pen…
Security Boundaries ✅ Passed PASS. The changed workflow path adds a literal, case-normalized allowlist containing only zoomote[bot]; it does not execute PR input or expand any secret/PII flow. The existing CI, draft, CodeRabbit…
Persistence Integrity ✅ Passed PASS — The pull request changes only author classification and diagnostic test coverage. The new codeRabbitEligibleAuthor branch routes zoomote[bot] through existing label, comment, and commit-sta…
Lifecycle Resource Cleanup ✅ Passed No changed lifecycle resource path exists. The workflow change only classifies zoomote[bot] as CodeRabbit-eligible and routes it through the existing label/status reconciliation path. The changed fi…
Title check ✅ Passed The title clearly identifies the main change: routing Roomote-authored pull requests through CodeRabbit. It is concise and related to the changeset, although the implementation uses the username `zoom…
Full details: Description check

Explanation

The description explains the change, rationale, scope, and covered scenarios. It does not follow the required template because it omits the Related GitHub Issue section, Test Procedure section, completed checklist, documentation-impact section, and contributor contact details.

Resolution

Add the required template sections. Link an approved issue, document exact test commands and verification steps, complete the pre-submission checklist, state whether documentation updates are required, and provide the requested contact information.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/enable-coderabbit-for-zoomote-3sg5r1hbj93nu

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: Mark the PR ready. Required CI must pass before CodeRabbit starts.

Review-state labels are managed by this workflow; do not edit them manually.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

edelauna
edelauna previously approved these changes Sep 11, 2026
@edelauna

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@edelauna

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@zoomote

zoomote Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Addressed in 039b1cd02: runWorkflow now exposes core.info, and the existing passing Zoomote/unrelated-bot cases assert coderabbit=pending and coderabbit=optional respectively. Existing label, gate, draft, and failing-CI assertions remain intact.

Validation: focused workflow tests 107/107 passed; full suite 8,252 passed and 39 skipped; lint, type checks, Prettier, and git diff --check passed. No review thread was available to resolve because the finding was reported in CodeRabbit's top-level pre-merge summary.

@edelauna

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions Bot added awaiting-ready CodeRabbit approved; waiting for the draft to be marked ready and removed awaiting-ready CodeRabbit approved; waiting for the draft to be marked ready labels Sep 11, 2026
@edelauna
edelauna marked this pull request as ready for review September 11, 2026 11:57
@edelauna
edelauna marked this pull request as draft September 11, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants