autoRelease config. Fixed usekey not stopping spells when hotkey doesn't need to be held. - #192
Open
cleannrooster wants to merge 2 commits into
Open
autoRelease config. Fixed usekey not stopping spells when hotkey doesn't need to be held.#192cleannrooster wants to merge 2 commits into
cleannrooster wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an unresolved bug when spells didn't need to have their hotkeys held via config - if a spell was bound to useKey (AKA rightclick) it couldn't be manually cancelled. This fixes that.
I also added an option for an AutoRelease config feature, where you can turn it off so that you can manually allow spells to resolve rather than casting immediately upon a spell finishing its cast. This allows people to "hold" their spells, for example if they want to turn a corner with a spell's cast time already prepared. I don't know if you want that for balance but I imagine a decent amount of people would actually like to use it.
I have tested both the fix and the feature and they both work.