feat: Additonal tests for request handlers.#969
Draft
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 95.57% | 95.47% | 🔴 -0.10% |
| Total | 92.49% | 92.49% | ⚪️ 0.00% |
Generated by coverage-comment.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refines task event processing and restoration logic to ensure protocol compliance, specifically by guaranteeing the first event in a stream is a Task object. It also updates documentation and adds integration tests for terminal and input-required task states. Feedback focuses on simplifying the task replacement logic in active_task.py and expanding test helper functions to handle more event types, which improves the consistency and robustness of the test suite.
bartek-w
changed the title
bartek-w
force-pushed
the
bartekw-task-restore
branch
2 times, most recently
from
59aee4f to
916c406
Compare
bartek-w
force-pushed
the
bartekw-task-restore
branch
from
916c406 to
e4debd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Printing error when AgentExecutor returns TaskStatusUpdateEvent instead of Task as a first message. Additionally TaskStatusUpdateEvent is replaced with Task objected as event.
Fixes #965