feat(explorer): add integration tests for new example json files#1702
feat(explorer): add integration tests for new example json files#1702josemontespg wants to merge 2 commits into
Conversation
…ngular, lit, and react
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive test suites for the Angular, Lit, and React renderers covering various UI layout and interaction scenarios, updates an import path in the Angular custom slider component, and configures the TypeScript base URL. The review feedback focuses on improving the Angular test files by recommending explicit TypeScript type casting for queried DOM elements to ensure strict type safety, and suggesting the use of specific component class selectors (such as .a2ui-button) instead of generic HTML tags to prevent matching unintended elements.
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
This LGTM! If CI is happy, I'm happy!
| let textContent: string; | ||
|
|
||
| beforeEach(async () => { | ||
| await loadExample('Complex Layout'); |
There was a problem hiding this comment.
Oof, we need to load the example from the filename instead of the title, so it's easier to map between the two. This is not blocking.
| import {Component, ChangeDetectionStrategy} from '@angular/core'; | ||
| import {CommonModule} from '@angular/common'; | ||
| import {CatalogComponent} from 'src/v0_9/core/catalog_component'; | ||
| import {CatalogComponent} from '@a2ui/angular/v0_9'; |
| { | ||
| "compileOnSave": false, | ||
| "compilerOptions": { | ||
| "baseUrl": ".", |
There was a problem hiding this comment.
This change may be fixing this issue:
If you can start the angular a2ui_explorer after this locally, can you link #1646 to this PR so it gets resolved when this lands?
| beforeEach(async () => { | ||
| container = await loadExample('00_formatted-text.json'); | ||
| surface = getSurface(container); | ||
| textContent = surface.textContent || ''; |
There was a problem hiding this comment.
I don't think we need to || '', but ok!
2 participants
Adds explorer integration tests for the new example json files in angular, lit, and react. Relates to #1497.