add material icons stylesheet link in basic catalog index#54
Open
jgindin wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the Material Icons stylesheet link to the index.html file of the ng-basic-catalog sample. The reviewer suggested optimizing the loading performance of this stylesheet by adding preconnect resource hints for the Google Fonts domains.
Contributor
⚡ A2UI Composer PR PreviewYour automated preview is successfully live:
|
Enables correct rendering of material icons inside the sandboxed preview iframe running the ng-basic-catalog app.
jgindin
force-pushed
the
fix-material-icons
branch
from
adfd139 to
d7903f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables correct rendering of material icons inside the sandboxed preview iframe running the ng-basic-catalog app.
Pre-launch Checklist