Gallery 1 shell link#56
Conversation
Enables correct rendering of material icons inside the sandboxed preview iframe running the ng-basic-catalog app.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request makes the 'Components Gallery' navigation link visible by default, removes the associated conditional signal, and updates the corresponding E2E and unit tests. It also adds support for stripping a JSON safety prefix when fetching the startup configuration, along with several new unit tests. The review feedback highlights two important issues: first, MatListItemHarness does not support getFullText(), so getText() should be used instead to avoid runtime errors; second, the regular expression used to strip the JSON safety prefix should be made more robust by using \s* instead of explicitly matching only a single newline.
⚡ A2UI Composer PR PreviewYour automated preview is successfully live:
|
* Use `QueryParser.` instead of `this.` when calling static functions * Ensure returned config.json doesn't have "JSON hijacking" prefixes
Remove the showComponentsGallery signal to expose the components gallery link in the primary navigation sidebar. Adds test coverage checking link visibility using shell harnesses.
jgindin
force-pushed
the
gallery-1-shell-link
branch
from
6131b9e to
b4b3978
Compare
1 participant
Description
Remove the showComponentsGallery signal to expose the components gallery link in the primary navigation sidebar.
This is the first in a series of PRs which culminates in a dynamically generated page to show the components of the current catalog:
Pre-launch Checklist