Remove four demo app classes from main navigation#618
Merged
Conversation
Repoint the Tree Table III launcher tile in demo_app_000 to z2ui5_cl_demo_app_116_0, which uses follow_up_action directly instead of the _event_client / cs_event-z2ui5 frontend-event path.
Repoint the Tree Table IV launcher tile in demo_app_000 to z2ui5_cl_demo_app_317_0, which expands the tree via a direct follow_up_action JS call instead of the _event_client / cs_event-expand_to_level frontend-event path.
Repoint the launcher tile in demo_app_000 to z2ui5_cl_demo_app_172_0, which keeps the input focused by injecting an inline sap.z2ui5.afterBE script and calling it via follow_up_action instead of the _event_client / cs_event-keyboard_keep_open frontend-event path.
Repoint the launcher tile in demo_app_000 to z2ui5_cl_demo_app_346_0, which tracks and restores cell focus via an inline focus-listener script plus a z2ui5.determineFocusId helper invoked through follow_up_action, instead of the _event_client / cs_event-set_focus_cell frontend-event path.
Drop the four generic_tile entries in demo_app_000 that referenced apps living under src/99/ (the 'obsolete' package): Focus (346_0), ui.Table III Focus Handling (172_0), Tree Table III Keep expanded state normal (116_0), and Tree Table IV Drag & Drop (317_0). The underlying _0 apps stay in src/99/ for reference.
Reintroduce the four launcher tiles for the apps living in the obsolete src/99/ folder (346_0 Focus, 172_0 ui.Table III Focus Handling, 116_0 Tree Table III, 317_0 Tree Table IV) under a new top-level Experimental panel bound to ms_check_expanded-experimental, keeping them visible without mixing them back into the regular Tables / Trees / Tiles sections.
Replace the standalone Experimental top-level panel with the existing Work in Progress sub-panel under UI5 Version Specific & WIP, which already serves the same purpose. The four obsolete-folder app tiles (346_0, 172_0, 116_0, 317_0) move there and the now-redundant ms_check_expanded-experimental flag is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed four demo app classes (
z2ui5_cl_demo_app_116,z2ui5_cl_demo_app_172,z2ui5_cl_demo_app_317, andz2ui5_cl_demo_app_346) and their corresponding metadata files from the repository. These apps are no longer exposed in the main demo app navigation menu.Changes
Deleted demo app classes:
z2ui5_cl_demo_app_116— Tree Table III (keep expanded state)z2ui5_cl_demo_app_172— ui.Table III (focus handling)z2ui5_cl_demo_app_317— Tree with Drag & Dropz2ui5_cl_demo_app_346— Table with focus edit controlsDeleted metadata files:
.clas.xmlfiles for all four classesUpdated navigation:
generic_tileentries fromz2ui5_cl_demo_app_000that linked to the deleted demo appsNotes
The demo app classes are completely removed from the codebase. The main navigation menu in the demo app launcher no longer displays tiles for these four examples.
https://claude.ai/code/session_01RJwNZ23z9vqWrD6Uu6q5iS