Skip to content

Commit b51f23e

Browse files
committed
Remove to_representation method
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent abf3815 commit b51f23e

1 file changed

Lines changed: 10 additions & 15 deletions

File tree

vulnerabilities/api.py

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -138,18 +138,16 @@ class VulnSerializerRefsAndSummary(BaseResourceSerializer):
138138
Lookup vulnerabilities references by aliases (such as a CVE).
139139
"""
140140

141-
def to_representation(self, instance):
142-
data = super().to_representation(instance)
143-
aliases = [alias["alias"] for alias in data["aliases"]]
144-
data["aliases"] = aliases
145-
return data
146-
147141
fixed_packages = MinimalPackageSerializer(
148142
many=True, source="filtered_fixed_packages", read_only=True
149143
)
150144

151145
references = VulnerabilityReferenceSerializer(many=True, source="vulnerabilityreference_set")
152-
aliases = AliasSerializer(many=True, source="alias")
146+
aliases = serializers.ListField(
147+
child=serializers.CharField(),
148+
source="aliases.values_list",
149+
read_only=True
150+
)
153151

154152
class Meta:
155153
model = Vulnerability
@@ -224,12 +222,6 @@ class PackageSerializer(BaseResourceSerializer):
224222
Lookup software package using Package URLs
225223
"""
226224

227-
def to_representation(self, instance):
228-
data = super().to_representation(instance)
229-
data["qualifiers"] = normalize_qualifiers(data["qualifiers"], encode=False)
230-
231-
return data
232-
233225
next_non_vulnerable_version = serializers.SerializerMethodField("get_next_non_vulnerable")
234226

235227
def get_next_non_vulnerable(self, package):
@@ -250,8 +242,13 @@ def get_latest_non_vulnerable(self, package):
250242

251243
fixing_vulnerabilities = serializers.SerializerMethodField("get_fixing_vulnerabilities")
252244

245+
qualifiers = serializers.SerializerMethodField()
246+
253247
is_vulnerable = serializers.BooleanField()
254248

249+
def get_qualifiers(self, package):
250+
return normalize_qualifiers(package.qualifiers, encode=False)
251+
255252
def get_fixed_packages(self, package):
256253
"""
257254
Return a queryset of all packages that fix a vulnerability with
@@ -335,8 +332,6 @@ class Meta:
335332
"fixing_vulnerabilities",
336333
]
337334

338-
is_vulnerable = serializers.BooleanField()
339-
340335

341336
class PackageFilterSet(filters.FilterSet):
342337
purl = filters.CharFilter(method="filter_purl")

0 commit comments

Comments
 (0)