feat: add dark mode toggle to nav bar with localStorage persistence - #760
Merged
Chucks1093 merged 1 commit intoAug 24, 2026
Merged
Conversation
Member
|
The inline script in the head for flash prevention is the right approach here. Doing it at the hook level would always be too late to avoid that brief white flash on dark mode page load. One thing worth checking is whether the invalid stored value fallback test covers what happens when a user has a stale value from an older version of the app that used a different storage key or format. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #750
Summary
useThemehook that reads the initial theme from localStorage, falls back to the OSprefers-color-schemewhen no stored value exists, applies thedarkclass to<html>on every change, and persists the chosen value under thethemekey in localStorage.<head>inindex.htmlthat runs before the first paint and applies the stored or OS-derived theme class to<html>immediately, preventing a white flash on dark-mode page load.darkclass addition and removal on<html>, localStorage persistence on mount and after toggling, and toggle state transitions.Test plan
darkclass on<html>and updates the UIlocalStorage['theme']after each toggleprefers-color-schemesettinguseThemepass