Skip to content

Add unit tests for get_balance returning zero for a wallet that has never transacted #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chucks1093 merged 3 commits into from
Aug 25, 2026
Merged

Add unit tests for get_balance returning zero for a wallet that has never transacted #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64efad8
Add unit tests for get_balance returning zero for a wallet that has n…
Godfrey-Delight Aug 24, 2026
58044ad
CI fix
Godfrey-Delight Aug 24, 2026
d3dacd4
fix(tests): supply missing whitelist_config parameter to register_cre…
Godfrey-Delight Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions creator-keys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,6 +2360,14 @@ impl CreatorKeysContract {
env.storage().persistent().get(&key).unwrap_or(0)
}

/// Read-only view: returns the key balance for a wallet and creator.
///
/// Alias for [`get_key_balance`](Self::get_key_balance). Returns `0` for any wallet address
/// that has never bought or been transferred keys, or that has sold all keys, without panicking or returning an error.
pub fn get_balance(env: Env, creator: Address, wallet: Address) -> u32 {
Self::get_key_balance(env, creator, wallet)
}

/// Read-only view: returns a stable view of a holder's key count for a creator.
///
/// Returns a [`HolderKeyCountView`] regardless of creator registration status.
Expand Down
1 change: 0 additions & 1 deletion ...test_snapshots/buy_at_max_supply_is_rejected_with_overflow_and_no_state_corruption.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
154 changes: 153 additions & 1 deletion ...tor-keys/test_snapshots/holder_count_tracks_distinct_buyers_and_decrements_on_exit.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -708,6 +707,159 @@
4095
]
],
[
{
"contract_data": {
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"vec": [
{
"symbol": "KeyBalance"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAITA4"
}
]
},
"durability": "persistent"
}
},
[
{
"last_modified_ledger_seq": 0,
"data": {
"contract_data": {
"ext": "v0",
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"vec": [
{
"symbol": "KeyBalance"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAITA4"
}
]
},
"durability": "persistent",
"val": {
"u32": 0
}
}
},
"ext": "v0"
},
4095
]
],
[
{
"contract_data": {
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"vec": [
{
"symbol": "KeyBalance"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK3IM"
}
]
},
"durability": "persistent"
}
},
[
{
"last_modified_ledger_seq": 0,
"data": {
"contract_data": {
"ext": "v0",
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"vec": [
{
"symbol": "KeyBalance"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAK3IM"
}
]
},
"durability": "persistent",
"val": {
"u32": 0
}
}
},
"ext": "v0"
},
4095
]
],
[
{
"contract_data": {
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"vec": [
{
"symbol": "KeyBalance"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMDR4"
}
]
},
"durability": "persistent"
}
},
[
{
"last_modified_ledger_seq": 0,
"data": {
"contract_data": {
"ext": "v0",
"contract": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD2KM",
"key": {
"vec": [
{
"symbol": "KeyBalance"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHK3M"
},
{
"address": "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMDR4"
}
]
},
"durability": "persistent",
"val": {
"u32": 0
}
}
},
"ext": "v0"
},
4095
]
],
[
{
"contract_data": {
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_100_creator_zero_protocol.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_50_50_equal_split.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_90_10_nominal_case.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
4 changes: 0 additions & 4 deletions creator-keys/test_snapshots/sell_fee_split_invariant_across_multiple_fee_configs.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -161,7 +160,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -284,7 +282,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -407,7 +404,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
10 changes: 0 additions & 10 deletions creator-keys/test_snapshots/sell_fee_split_invariant_across_price_range.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -161,7 +160,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -284,7 +282,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -407,7 +404,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -530,7 +526,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -653,7 +648,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -776,7 +770,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -899,7 +892,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -1022,7 +1014,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down Expand Up @@ -1145,7 +1136,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_boundary_odd_price_999.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_boundary_price_one.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_boundary_price_two.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_deterministic_assertions.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_large_amount.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
1 change: 0 additions & 1 deletion creator-keys/test_snapshots/sell_fee_split_invariant_max_protocol_50_percent.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"void",
"void",
"void",
"void",
"void"
]
}
Expand Down
Loading
Loading