fix compiling errors in windows - #6
Conversation
|
|
||
| if is_link { | ||
| let link_dest = std::fs::read_link(&p).unwrap(); | ||
| #[cfg(target_os = "unix")] |
There was a problem hiding this comment.
I don't know much about windows file system, but should't it be https://doc.rust-lang.org/std/os/windows/fs/fn.symlink_file.html for windows instead of just skipping?
|
Can you tell me the target of the symlink feature? Should there be a symlink in the targetfolder pointing to the original symlink target. Or a realfile with the name of the original symlinkname? In the moment It seams that it will copy the symlink target file with the original filename. Regardless if I use std::os::windows::fs::symlink_file or not. That fits to my expectation that windows symlinks are crap. mostly they never work as expected. And after 15 years as windows admin I only tried it 2 times. Never successfully. My opinion is to skip this in windows because feature is not working. |
|
I trust your expertise, and I'm ok with skip symlinks at all at windows. So, should I merge this PR with |
2 participants
tiny fixes to avoid compiling errors