Migrate code to Swift 3 - #6
Open
troyshu wants to merge 23 commits into
Open
Conversation
This reverts commit 208103a.
…g on an actual iPhone device / no crashing run time errors
…rt, responsive. Though drawing of the "chart" itself still isn't responsive
…nt sized screens)
This reverts commit 4ad3317.
…t extension to speed build, due to a bug in swift
…loyment target to iOS 9+ (because of UIStackView)
…to default time range
…improve their spacing too
sbilling
approved these changes
Aug 10, 2017
vBoykoGit
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I migrated the codebase to Swift 3. First, I used Xcode's automatic code migration function. Then, I fixed the remaining build errors manually, to adhere to Swift 3 syntax. I manually tested the app (on my iPhone, in the simulator for various iPhone models), everything works and looks as expected.
Not sure if this was introduced in the migration, but the app's design degrades a little on iPhone SE. It looks fine on other screen sizes, but I guess another todo is to make the design properly responsive.Many of the commits after the "Upgrade to Swift 3" one were to make the stock price chart and date range select buttons responsive to different screen sizes and device rotation.I also committed the updated Alamofire pod to the repo. I'm new to Swift development, Cocoapod, etc. so there's probably a bunch of cleanup that needs to be done.