feat(status): add rift status - #495
Draft
ericwang401 wants to merge 4 commits into
Draft
ericwang401 wants to merge 4 commits into
ericwang401 wants to merge 4 commits into
Conversation
find_rift_executable searched $PATH before looking at itself, so `rift service start` from a dev build wrote a plist pointing at Homebrew's rift and restarted that instead -- silently managing a different install than the one invoked. current_exe comes first now. macOS reports the path a binary was invoked through rather than resolving it, so a Homebrew invocation still records the stable bin/rift symlink rather than a Cellar path that the next version bump moves. $PATH stays as the last resort for `rift-cli service`, which is not the agent and has to go looking for one.
Nothing reported whether rift was up. The only test was to run a query and read the error, which cannot tell "not running" from "registered but not answering" -- and the scripting addition's health lived in a separate command again. Three probes, reported separately so the output says which one to fix. The window manager check round-trips a real metrics query rather than only looking the Mach service up. The launchd check looks for Homebrew's labels as well as rift's own, because `brew services` starts rift under homebrew.mxcl.rift and checking only git.acsandmann.rift reports a healthy install as "not installed". Exit status follows the window manager alone: rift runs without the scripting addition, so a missing payload is reported, not failed.
`rift --version` prints the build. The metrics query carries the version of the rift that answers, so `rift status` can name it in the window manager row and say when it is not the version of the binary asking -- the state every upgrade leaves behind until the service restarts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: This pull request was vibe coded with Claude Opus 5 and Fable 5/5.1.
Summary
rift statuswith human-readable and JSON outputDependency
Drafted on top of #494. Until that PR merges, GitHub shows its shared CLI refactor in this diff as well.
Testing
cargo check --workspacecargo test --workspace --no-run