Skip to content

feat: map privilege-apply business errors in dms-kit - #893

Merged
LordofAvernus merged 3 commits into
mainfrom
dms-ui/feat-982
Sep 15, 2026
Merged

LordofAvernus merged 3 commits into
mainfrom
dms-ui/feat-982

Conversation

@LordofAvernus

@LordofAvernus LordofAvernus commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Map privilege-apply business errors in dms-kit, including duplicate-open and invalid account name

Problem

CE and EE UIs share dms-kit error mapping. These messages must land on dms-ui main and reach main-ee through Sync, not through an EE-only feature PR.

Test plan

  • privilege_apply.duplicate_open and privilege_apply.invalid_account_name map to the expected messages
  • No DMS PrivilegeApply HTTP client is added on CE

Fixes actiontech/dms-ee#982

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 80.57% 30313/37621
🟡 Branches 62.85% 11425/18178
🟢 Functions 83.99% 10191/12134
🟢 Lines 84.41% 28976/34329

Test suite run success

3777 tests passing in 826 suites.

Report generated by 🧪jest coverage report action from 28af13e

@LordofAvernus LordofAvernus changed the title feat: add privilege-apply API client and business error mapping feat: map privilege-apply business errors in dms-kit Sep 10, 2026
Surface no-assignee, duplicate-open and invalid account name from
provision using the shared error mapper.
Re-encode from/compression_data after URLSearchParams decode so +
is not turned into a space. Wait until user projects are loaded
before resolving the target project.
Approve failures previously toasted the raw backend key.
@LordofAvernus
LordofAvernus merged commit 1c8de0f into main Sep 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant