Skip to content

fix(mysql): enable window function parsing in ParseOneSql #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iwanghc merged 1 commit into from
Aug 26, 2026
Merged

fix(mysql): enable window function parsing in ParseOneSql #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqle/driver/mysql/util/parser_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ func ParseSql(sql string) ([]ast.StmtNode, error) {

func ParseOneSql(sql string) (ast.StmtNode, error) {
p := parser.New()
p.EnableWindowFunc(true)
stmt, err := p.ParseOneStmt(sql, "", "")
if err != nil {
fmt.Printf("parse error: %v\nsql: %v", err, sql)
Expand Down
20 changes: 20 additions & 0 deletions sqle/driver/mysql/util/parser_helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,23 @@ func testFingerprint(t *testing.T, input, expect string) {
}
assert.Equal(t, expect, actual)
}

func TestParseOneSqlWindowFunc(t *testing.T) {
const sql = `SELECT id, ROW_NUMBER() OVER (PARTITION BY dept ORDER BY salary DESC) AS rn FROM emp;`
stmt, err := ParseOneSql(sql)
assert.NoError(t, err)

selectStmt, ok := stmt.(*ast.SelectStmt)
assert.True(t, ok)
assert.NotNil(t, selectStmt.Fields)

foundWindow := false
for _, field := range selectStmt.Fields.Fields {
if _, ok := field.Expr.(*ast.WindowFuncExpr); ok {
foundWindow = true
break
}
}
assert.True(t, foundWindow, "expected AST to contain WindowFuncExpr")
}

Loading