Skip to content

Implement module-by-module cell sorting#1265

Open
stephenswat wants to merge 1 commit into
acts-project:mainfrom
stephenswat:feat/better_sorting
Open

Implement module-by-module cell sorting#1265
stephenswat wants to merge 1 commit into
acts-project:mainfrom
stephenswat:feat/better_sorting

Conversation

@stephenswat

@stephenswat stephenswat commented Feb 20, 2026

Copy link
Copy Markdown
Member

This commit adds a cell sorting option to the clustering algorithm which allows the code to accept cells for which modules are contiguous but for which cells are not necessarily ordered within each module.

@stephenswat stephenswat added the feature New feature or request label Feb 20, 2026
@stephenswat stephenswat marked this pull request as draft February 20, 2026 22:58
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@stephenswat stephenswat reopened this Jun 30, 2026
@stephenswat stephenswat force-pushed the feat/better_sorting branch from 09cebb7 to f902c54 Compare June 30, 2026 13:47
@stephenswat

Copy link
Copy Markdown
Member Author

@flg

@stephenswat stephenswat force-pushed the feat/better_sorting branch from 7d4846b to 1036de2 Compare July 3, 2026 08:52

@krasznaa krasznaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as all build issues are resolved, we should get this in with some haste.

Comment thread device/common/src/clusterization/clusterization_algorithm.cpp
Comment thread device/common/include/traccc/clusterization/device/reify_cluster_data.hpp Outdated
@stephenswat stephenswat force-pushed the feat/better_sorting branch 3 times, most recently from 42da788 to d700d52 Compare July 6, 2026 13:51
@stephenswat stephenswat marked this pull request as ready for review July 6, 2026 14:18
@stephenswat stephenswat force-pushed the feat/better_sorting branch from d700d52 to d7ed09c Compare July 6, 2026 14:18
This commit adds a cell sorting option to the clustering algorithm which
allows the code to accept cells for which modules are contiguous but for
which cells are not necessarily ordered within each module.
@stephenswat stephenswat force-pushed the feat/better_sorting branch from d7ed09c to 2011c8d Compare July 7, 2026 11:58
@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants