fix(advisor): prevent unsafe repository auto-detection#810
Draft
wattswolf wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
owner/namematch before advisor auto-scopes to a connected repositorygit remote get-url originexecution for advisor scope, sticky scope, sync caching, and sync telemetryWhy
AK-411 follows up on review feedback from actual-cli #807. The prior name-only fallback could silently scope an advisor query to an unrelated connected repository with the same name. Three other call sites also carried near-identical origin-remote subprocess implementations.
Jira: AK-411
Validation
cargo fmt --checkcargo clippy -- -D warningscargo build --releasecargo test -p tui-test --lib: 222/222 passed50d532e43347e78e5433b9bf2ef393b200137cd3: PASS, zero findingsRisk and rollback
Risk is limited to repository auto-detection and shared origin lookup. A lookup failure or non-exact match degrades to the existing organization-level query. Rollback is a revert of the three commits.