[pull] trunk from SeleniumHQ:trunk#788
Merged
Merged
Conversation
… format (#17669) * [py] translate continue_request/continue_response kwargs to BiDi wire format The high-level Request.continue_request and Response.continue_response accepted **kwargs and merged them straight onto the wire params. This bypassed the snake_case to camelCase translation (status -> statusCode, reason_phrase -> reasonPhrase) and the value encoders used everywhere else in this layer, so pythonic calls like continue_response(status=503) or continue_request(headers={...}) silently sent wrong or untranslated values. Replace the kwargs with explicit keyword-only params matching the set_* mutators and route them through _continue_params so they are translated uniformly while still overriding recorded mutations. * [py] add tests for continue_* override merge and falsy values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )