feat: add Promo_Champions_V2.1 ECC bundle - #81
Conversation
…ions_V2.1/SKILL.md)
…ions_V2.1/SKILL.md)
…ions_V2.1/agents/openai.yaml)
…ts/inherited/Promo_Champions_V2.1-instincts.yaml)
|
|
||
| ### Naming Conventions | ||
|
|
||
| | Element | Convention | | ||
| |---------|------------| | ||
| | Files | snake_case | | ||
| | Functions | camelCase | |
There was a problem hiding this comment.
Inaccurate file-naming convention
This implicitly invocable skill instructs agents to use snake_case filenames, while the repository predominantly uses PascalCase for React components and camelCase for helpers. Following this guidance will introduce files inconsistent with the surrounding codebase and create avoidable naming churn.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .agents/skills/Promo_Champions_V2.1/SKILL.md
Line: 65-71
Comment:
**Inaccurate file-naming convention**
This implicitly invocable skill instructs agents to use snake_case filenames, while the repository predominantly uses PascalCase for React components and camelCase for helpers. Following this guidance will introduce files inconsistent with the surrounding codebase and create avoidable naming churn.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| args = ["-y", "@modelcontextprotocol/server-github"] | ||
|
|
||
| [mcp_servers.context7] | ||
| command = "npx" | ||
| args = ["-y", "@upstash/context7-mcp@latest"] | ||
|
|
||
| [mcp_servers.exa] | ||
| url = "https://mcp.exa.ai/mcp" | ||
|
|
||
| [mcp_servers.memory] | ||
| command = "npx" | ||
| args = ["-y", "@modelcontextprotocol/server-memory"] | ||
|
|
||
| [mcp_servers.playwright] | ||
| command = "npx" | ||
| args = ["-y", "@playwright/mcp@latest", "--extension"] | ||
|
|
||
| [mcp_servers.sequential-thinking] |
There was a problem hiding this comment.
The npm-backed MCP definitions use npx -y with unversioned packages or mutable latest tags, so identical repository revisions can execute different third-party code over time in a workspace-write session. Pin reviewed immutable versions to make execution reproducible and reduce supply-chain exposure.
How this was verified: The configuration combines sandbox_mode = "workspace-write" with mutable npm package resolution for the configured MCP processes.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .codex/config.toml
Line: 10-27
Comment:
**Mutable MCP package execution**
The npm-backed MCP definitions use `npx -y` with unversioned packages or mutable `latest` tags, so identical repository revisions can execute different third-party code over time in a workspace-write session. Pin reviewed immutable versions to make execution reproducible and reduce supply-chain exposure.
**How this was verified:** The configuration combines `sandbox_mode = "workspace-write"` with mutable npm package resolution for the configured MCP processes.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary
Auto-generated ECC bundle from repository analysis.
What This Does
Merging this PR adds repo-local ECC artifacts for both Claude Code and Codex. The generated bundle captures repository patterns, Codex baseline config, and reusable workflow scaffolds derived from git history analysis.
Analysis Scope
Files
.claude/ecc-tools.json.claude/skills/Promo_Champions_V2.1/SKILL.md.agents/skills/Promo_Champions_V2.1/SKILL.md.agents/skills/Promo_Champions_V2.1/agents/openai.yaml.claude/identity.json.codex/config.toml.codex/AGENTS.md.codex/agents/explorer.toml.codex/agents/reviewer.toml.codex/agents/docs-researcher.toml.claude/homunculus/instincts/inherited/Promo_Champions_V2.1-instincts.yamlOptional: Continuous Learning (6 instincts)
This PR also includes instincts for the continuous-learning-v2 skill. These are optional and only useful if you use that skill.
Import after merging:
Review Checklist
ECC Tools | Everything Claude Code
Summary by cubic
Adds repo-local ECC config for Claude Code and Codex, auto-generated from analysis of this repository's history and structure. The bundle adds repo skills, Codex multi-agent roles, an MCP baseline, and an install manifest; no existing files are modified.
What's included
.claude/skills/and.agents/skills/encodes detected conventions for commits, naming, imports/exports, and tests..codex/config.tomlenables MCP servers and read-only explorer, reviewer, and docs-researcher roles..claude/ecc-tools.jsonis the install manifest tracking all managed files for upgrades, repair, and uninstall..claude/homunculus/instincts/inherited/adds optional continuous-learning instincts; import with/instinct-importif you use the continuous-learning-v2 skill..claude/identity.jsonsets a suggested baseline (technical, detailed, TypeScript-focused).Review focus
Written for commit 700df2c. Summary will update on new commits.
Greptile Summary
The PR adds an auto-generated ECC bundle for Claude Code and Codex, including repository skills, agent roles, MCP configuration, identity metadata, and continuous-learning instincts.
Confidence Score: 4/5
The PR appears safe to merge after considering two non-blocking improvements: correcting inaccurate repository guidance and pinning executable MCP dependencies.
The bundle files and manifest are structurally present, but the generated naming convention conflicts with the existing codebase and the MCP baseline executes mutable npm package resolutions.
Files Needing Attention: .agents/skills/Promo_Champions_V2.1/SKILL.md, .claude/skills/Promo_Champions_V2.1/SKILL.md, .codex/config.toml
Security Review
The npm-backed MCP definitions resolve mutable package releases at invocation time. Pinning immutable reviewed versions would make execution reproducible and reduce supply-chain exposure in workspace-write sessions.
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat: add Promo_Champions_V2.1 ECC bundl..." | Re-trigger Greptile