fix(desktop): menus/popovers on ladder rungs instead of z-50 literals - #6
Conversation
Second pass of the DESIGN.md overlay-ladder audit (first pass: OverlayView, PR #4). Ported menus and popovers off the z-50 literal onto the z ladder: - context-menu.tsx / dropdown-menu.tsx / popover.tsx (Radix primitives, portaled to body): z-50 -> z-(--z-modal-popover) (140) - starmap/node-context-menu.tsx: backdrop -> z-(--z-modal-backdrop), menu -> z-(--z-modal-popover) - find-bar.tsx (fixed command surface): z-50 -> z-(--z-over-modal) (200) Remaining z-50 are local in-component stacking (tree drop targets with documented intent, composer/terminal overlays) — allowed by DESIGN.md ('plain z-10/z-20 for stacking within one component'). Verification: tsc 0 new errors (5 pre-existing frimousse dep errors), eslint 0, vitest 60/60 (find-bar 48, no-native-title, starmap share).
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
O que é
Segunda passada da auditoria de design do Desktop (DESIGN.md — escada de z-index). Primeira passada: OverlayView (PR #4). Esta: menus e popovers que ainda usavam
z-50literal.Mudanças
src/components/ui/context-menu.tsx(2x) — Radix primitiva portada ao body:z-50→z-(--z-modal-popover)(140)src/components/ui/dropdown-menu.tsx(2x) — idemsrc/components/ui/popover.tsx(1x) — idemsrc/app/starmap/node-context-menu.tsx— backdrop →z-(--z-modal-backdrop), menu →z-(--z-modal-popover)src/components/find-bar.tsx— superfície de comando fixa →z-(--z-over-modal)(200)Fora do escopo (intencional):
z-50restantes são stacking local DENTRO de componentes (drop targets do tree com comentário de intenção documentado, overlays do composer/terminal) — o DESIGN.md permite z local em componente.Verificação
tsc --noEmit: 0 erros novos (5 erros pré-existentes de dependênciafrimoussedo upstream, não relacionados)eslintnos 5 arquivos: 0 errosvitest: 60/60 passando (find-bar 48, no-native-title, starmap share)5 arquivos, +8/-8.
Summary by cubic
Replaced hardcoded
z-50with the z-index ladder in DESIGN.md for desktop menus, popovers, and the find bar. Fixes stacking quirks and makes overlays consistent; remainingz-50are intentional local stacks.context-menu.tsx,dropdown-menu.tsx,popover.tsxnow usesz-(--z-modal-popover).z-(--z-modal-backdrop), menuz-(--z-modal-popover).z-(--z-over-modal).Written for commit 96cb79d. Summary will update on new commits.